Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#3997] Move Javascript generators from Samples to "generators" - Echo Bot #4011

Merged
merged 4 commits into from
Jan 20, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #3997
#minor

Description

This PR adds the generator-botbuilder project and the Echo bot from the BotBuider-Samples repository.
It also includes the root documentation for the folder.

Detailed Changes

  • Added generators/generator-botbuilder project.
  • Added Echo bot templates for JS and TS versions.
  • Added docs and config files to the root folder.

Testing

These images show the generator-botbuilder working for the Echo bot.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 13, 2021 18:14
@ceciliaavila ceciliaavila changed the title [#3997] Move Javascript generators from Samples to "generators" - Echo Bot feat: [#3997] Move Javascript generators from Samples to "generators" - Echo Bot Dec 13, 2021
@ceciliaavila
Copy link
Collaborator Author

Hi @BruceHaley, this is the first PR of the series to move the JS generators from BotBuilder-Samples. Please let us know if you have any questions.
Thanks!

@coveralls
Copy link

coveralls commented Dec 13, 2021

Pull Request Test Coverage Report for Build 1721283585

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.545%

Totals Coverage Status
Change from base Build 1721274908: -0.003%
Covered Lines: 19667
Relevant Lines: 22035

💛 - Coveralls

Copy link
Contributor

@BruceHaley BruceHaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrivera-ms mrivera-ms merged commit bd4bcb5 into main Jan 20, 2022
@mrivera-ms mrivera-ms deleted the southworks/add/generators-botbuilder-echo branch January 20, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants