Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test failures in E2E_BF-Streaming-DL-ASE_Test #3910

Merged
merged 1 commit into from
Aug 27, 2021
Merged

fix: test failures in E2E_BF-Streaming-DL-ASE_Test #3910

merged 1 commit into from
Aug 27, 2021

Conversation

BruceHaley
Copy link
Contributor

Fixes #3909

Description

In pipeline E2E_BF-Streaming-DL-ASE_Test, npm test is failing with the following error:

  1. Chrome
    should receive an echo after sending a message:
    TimeoutError: Waiting 2 activities is shown
    Wait timed out after 60092ms

Example here: https://dev.azure.com/FuseLabs/SDK_v4/_build/results?buildId=265656&view=logs&j=c0efd2c7-3dad-5cdf-75e8-16ff3f47c553&t=924c193e-0db3-54a8-b081-a097a2346a3d

Specific Changes

Add retries to the test.

Example of succeeding build: https://dev.azure.com/FuseLabs/SDK_v4/_build/results?buildId=265810&view=results

@BruceHaley BruceHaley requested a review from a team as a code owner August 27, 2021 00:05
@BruceHaley BruceHaley changed the title Fix test failures in E2E_BF-Streaming-DL-ASE_Test Fix: test failures in E2E_BF-Streaming-DL-ASE_Test Aug 27, 2021
@BruceHaley BruceHaley changed the title Fix: test failures in E2E_BF-Streaming-DL-ASE_Test fix: test failures in E2E_BF-Streaming-DL-ASE_Test Aug 27, 2021
@coveralls
Copy link

coveralls commented Aug 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1172438055

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 84.511%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 86.21%
Totals Coverage Status
Change from base Build 1148586804: -0.003%
Covered Lines: 19636
Relevant Lines: 22008
💛 - Coveralls

@BruceHaley BruceHaley added Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. bug Indicates an unexpected problem or an unintended behavior. labels Aug 27, 2021
@mrivera-ms mrivera-ms merged commit a393006 into main Aug 27, 2021
@mrivera-ms mrivera-ms deleted the bruce/streamingtestfix8-26 branch August 27, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrivera-ms mrivera-ms mrivera-ms approved these changes

@joshgummersall joshgummersall joshgummersall approved these changes

Assignees
No one assigned
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failures in E2E_BF-Streaming-DL-ASE_Test
4 participants
@BruceHaley @coveralls @joshgummersall @mrivera-ms