Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blobs transcript date filter #3877

Merged
merged 2 commits into from
Jul 21, 2021
Merged

fix: blobs transcript date filter #3877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
238a90d
fix: blobs transcript date filter
Jul 21, 2021
d59b36d
Merge branch 'main' into jpg/fix-blobs-transcript-date-filter
Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions libraries/botbuilder-azure-blobs/src/blobsTranscriptStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import * as z from 'zod';
import getStream from 'get-stream';
import pmap from 'p-map';
import { Activity, PagedResult, TranscriptInfo, TranscriptStore } from 'botbuilder-core';
import { maybeCast } from 'botbuilder-stdlib/lib/maybeCast';
import { maybeCast } from 'botbuilder-stdlib';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix here, auto-import included the wrong path before.

import { sanitizeBlobKey } from './sanitizeBlobKey';

import {
Expand Down Expand Up @@ -141,8 +141,7 @@ export class BlobsTranscriptStore implements TranscriptStore {
const fromIdx =
startDate != null
? blobItems.findIndex(
(blobItem) =>
blobItem?.metadata?.timestamp && new Date(blobItem.metadata.timestamp) >= startDate
(blobItem) => blobItem?.properties?.createdOn && blobItem?.properties?.createdOn >= startDate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I logged the blobItems array and found that metadata is undefined by default, so I opted for this property that does exist. I tested against a real blob storage container.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is createdOn already a Date() obj?

This change still works with local storage emulation, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, yes. I'll test with the emulator as well. It should as the Typescript type definitions should be correct. Will double check though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdrichardson Emulator checks out!

)
: 0;

Expand Down