fix: enable TeamsInfo methods to work with CloudAdapter #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrichardson
commented
Jun 30, 2021
Pull Request Test Coverage Report for Build 987633141
💛 - Coveralls |
stevengum
approved these changes
Jun 30, 2021
joshgummersall
approved these changes
Jun 30, 2021
joshgummersall
pushed a commit
that referenced
this pull request
Jun 30, 2021
joshgummersall
pushed a commit
that referenced
this pull request
Jun 30, 2021
* port: orchestrator package changes (#3824) Fixes #3782 * chore: tests for cloud adapter (#3833) * chore: tests for cloud adapter base * chore: tests for cloud adapter * fix: assert error messages * fix: enable TeamsInfo methods to work with CloudAdapter (#3830) * fix: trigger github workflows on 4.14 Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
Many of the TeamsInfo methods fail with "This method requires a connector client." when using
CloudAdapter. This is because most of them have a check foradapter.createConnectorClient(), which doesn't exist in CloudAdapter.Specific Changes
Align JS TeamsInfo with .NET by having the adapter get pulled from the
TurnState.Testing
This also required a lot of testing changes since the adapter didn't exist on the
TurnStatein the tests. The JS tests now manually add the adapter to theTurnState, as also done in .NET.