Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: Fix: add cache for luis recognizer result to avoid extra requests #3829

Merged
merged 14 commits into from
Jul 2, 2021

Conversation

cosmicshuai
Copy link
Contributor

closes: #3806
In order to avoid two LUIS network calls from the child dialog for the same user query when interruptions are enabled.
In this PR, Luis Recognizer would cache the luis result for each turn, using endpoint combines with application id as the key.

@cosmicshuai
Copy link
Contributor Author

@joshgummersall
Hi Josh, as Steve mentioned, the LuisRecognizer already has the cache. In order to port the test, I've changed a lot code in testScript and LuisAdaptiveRecognizer. I am wondering whether it is worth to do that? Or is there a better way to write this test?

@joshgummersall
Copy link
Contributor

Nice work! Is this "Ready for Review" aka ready to merge?

@coveralls
Copy link

coveralls commented Jul 2, 2021

Pull Request Test Coverage Report for Build 994516615

  • 24 of 26 (92.31%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 84.364%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive-testing/src/testActions/assertTelemetryContains.ts 13 15 86.67%
Totals Coverage Status
Change from base Build 994516144: 0.06%
Covered Lines: 19659
Relevant Lines: 22112

💛 - Coveralls

@cosmicshuai cosmicshuai marked this pull request as ready for review July 2, 2021 16:20
@cosmicshuai cosmicshuai requested review from chrimc62, tomlm and a team as code owners July 2, 2021 16:20
@joshgummersall joshgummersall merged commit 290c7e0 into main Jul 2, 2021
@joshgummersall joshgummersall deleted the shuwan/portLuisCache branch July 2, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Fix: add cache for luis recognizer result to avoid extra requests (#5683)
3 participants