-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port: Fix: add cache for luis recognizer result to avoid extra requests #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@joshgummersall |
libraries/botbuilder-dialogs-adaptive-testing/tests/luisAdaptiveRecognizer.test.js
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive-testing/src/mocks/mockLuisRecognizer.ts
Outdated
Show resolved
Hide resolved
Nice work! Is this "Ready for Review" aka ready to merge? |
Pull Request Test Coverage Report for Build 994516615
💛 - Coveralls |
joshgummersall
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3806
In order to avoid two LUIS network calls from the child dialog for the same user query when interruptions are enabled.
In this PR, Luis Recognizer would cache the luis result for each turn, using endpoint combines with application id as the key.