Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build label before state label #3828

Merged
merged 3 commits into from
Jul 2, 2021
Merged

fix: build label before state label #3828

merged 3 commits into from
Jul 2, 2021

Conversation

joshgummersall
Copy link
Contributor

.NET does versions like 4.14.0-rc0.preview, i.e. the "build label" comes before "preview".

#minor

fix: build label before state label
2aca6a9 
.NET does versions like 4.14.0-rc0.preview, i.e. the "build label" comes before "preview".
@joshgummersall joshgummersall requested a review from a team as a code owner June 29, 2021 16:49
@coveralls
Copy link

coveralls commented Jun 29, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 994368750

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.319%
Totals Coverage Status
Change from base Build 994303283: 0.0%
Covered Lines: 19629
Relevant Lines: 22083
💛 - Coveralls

@mdrichardson
Copy link
Contributor

does .NET do it like that?

From here

I don't see recent preview packages
image
image

@joshgummersall
Copy link
Contributor Author

@mdrichardson only for packages still considered preview, check out the debugging package.

mdrichardson
mdrichardson approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@mdrichardson mdrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Missed that one.

@joshgummersall joshgummersall merged commit 159c7c5 into main Jul 2, 2021
@joshgummersall joshgummersall deleted the jpg/semver-tweaks branch July 2, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrichardson mdrichardson mdrichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @coveralls @mdrichardson