Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adaptive expressions divide function #3528

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Fix adaptive expressions divide function #3528

merged 4 commits into from
Apr 7, 2021

Conversation

stefangomez
Copy link
Contributor

Fixes #3527

Description

Corrects the expected result for floats in a divide expression

Specific Changes

  • changed the return value for Divide to only do a Math.floor if both args are Integers

Testing

  • added tests for div(11.2, 2) and 11.2 / 2

@stefangomez stefangomez requested review from a team as code owners April 6, 2021 04:43
@stefangomez stefangomez requested review from chrimc62 and tomlm April 6, 2021 04:43
@ghost
Copy link

ghost commented Apr 6, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@coveralls
Copy link

coveralls commented Apr 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 724681759

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 84.945%
Totals Coverage Status
Change from base Build 724679740: 0.006%
Covered Lines: 18972
Relevant Lines: 21276
💛 - Coveralls

@Danieladu
Copy link
Contributor

LGTM

@Danieladu Danieladu added the Area: Adaptive expression The issue is related to Adaptive expressions label Apr 6, 2021
@stevengum stevengum merged commit b5feba0 into microsoft:main Apr 7, 2021
@stevengum
Copy link
Member

@stefangomez thank you for filing the issue and creating this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danieladu Danieladu Danieladu left review comments

@stevengum stevengum stevengum approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
Area: Adaptive expression The issue is related to Adaptive expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptive Expressions 'divide' with float is not returning a float
4 participants
@stefangomez @coveralls @Danieladu @stevengum