bug: Fix OrchestratorRecognizer null checks

[taicchoumsft]

Closes #3073

Description

Fix the Orchestrator null check on Initialize() to be consistent at lines 156 and 299

Specific Changes

• Change null check at line 299 to match line 156

Testing

Unit tests added to catch cases where either the orchestrator or labelResolver objects are not initialized before score is called (would have failed this test before).

[joshgummersall]

Tests are a lot cleaner with async syntax.

it('Expect initialize is called when orchestrator obj is null', async () => {
        //if labelresolver is null, initialize() must be called
        const result = [
            {
                score : 0.9,
                label : {
                    name : "mockLabel"
                }
            }
        ];

        const mockResolver = new MockResolver(result);
        const testPaths = "test";

        const rec = new OrchestratorAdaptiveRecognizer(testPaths, testPaths, mockResolver);
        OrchestratorAdaptiveRecognizer.orchestrator = null;

        rec.Initialize = sinon.fake();

        const {dc, activity} = createTestDcAndActivity("hello");
        const res = await rec.recognize(dc, activity);
        assert(res);
       ...
});

[taicchoumsft]

Thanks @joshgummersall, changed all usage of recognize to async syntax.

[joshgummersall]

Same here - in fact, you can do:

await assert.rejects(() => rec.recognize(dc, activity);

to ensure that rec.recognize fails.

[taicchoumsft]

awesome, thanks @joshgummersall. Addressed.

[coveralls]

Pull Request Test Coverage Report for Build 369070518

• 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 84.782%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts	0	1	0.0%

Totals
Change from base Build 368669785:	0.02%
Covered Lines:	17305
Relevant Lines:	19491

---

💛 - Coveralls