Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammatical typo #3069

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Grammatical typo #3069

merged 4 commits into from
Nov 18, 2020

Conversation

alopix
Copy link
Contributor

@alopix alopix commented Nov 17, 2020

Description

By coincidence found a grammatical typo.

Specific Changes

  • it's should be its

Testing

Changes the test and code together.

@coveralls
Copy link

coveralls commented Nov 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 368795043

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 84.779%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/node.ts 2 95.26%
Totals Coverage Status
Change from base Build 368669785: 0.02%
Covered Lines: 17304
Relevant Lines: 19491
💛 - Coveralls

stevengum
stevengum approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely approved. :shipit:

@stevengum stevengum merged commit 853b533 into microsoft:main Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@joshgummersall joshgummersall joshgummersall approved these changes

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

@johnataylor johnataylor Awaiting requested review from johnataylor

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alopix @coveralls @joshgummersall @stevengum