Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make adaptive expression library compatible with IE #2906

Merged
merged 9 commits into from
Oct 20, 2020
Merged

make adaptive expression library compatible with IE #2906

merged 9 commits into from
Oct 20, 2020

Conversation

atishayv
Copy link
Contributor

##Fixes:
Make adaptive expression library compatible with IE

Description

There was no support of IE in the adaptive expression library. Using babel to transpile compiled code and add polyfills so that it works in IE also.

Specific Changes

  • Using babel to transpile adaptive-expression and other dependent libraries which are not compatible with IE.
  • Adding core js to resolve all polyfills which are used in those dependent libraries.
  • Updated templating library package json to create a webpack build in dist folder which is compatible with IE

Testing

Tested manually by taking dependecy in adaptive card designer in IE to make sure that there are no errors

@atishayv atishayv requested review from joshgummersall, stevengum and a team as code owners October 16, 2020 15:14
@atishayv
Copy link
Contributor Author

CC: @dclaux, @jaisanth

Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, can you verify that this bundle still works for your use case as well?

libraries/adaptive-expressions-ie11/webpack.config.js Outdated Show resolved Hide resolved
@atishayv
Copy link
Contributor Author

One small comment, can you verify that this bundle still works for your use case as well?

Yes, I did verify it with adaptive-designer. I had to add aliases for the same but it worked. These are the 3 changes I did :

  1. package json, I removed the expression dependency and added dependency for ie 11 :
    image
  2. Added alias in webpack:
    image
  3. Added alias in tsconfig:
    image

CC : @dclaux, @jaisanth

@atishayv atishayv closed this Oct 20, 2020
@atishayv atishayv reopened this Oct 20, 2020
@atishayv
Copy link
Contributor Author

Sorry, by mistake i closed the PR. Have reopened it

Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your work on this 👍

@atishayv
Copy link
Contributor Author

atishayv commented Oct 20, 2020

Looks good to me! Thanks for your work on this 👍

Thanks. Can we merge this ?

"set-version": "npm version --allow-same-version ${Version}"
},
"files": [
"src",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any benefit to us including "src"? If someone wanted to use the "src", they should likely instead use adaptive-expressions, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for pushing those changes

@joshgummersall joshgummersall merged commit 1498b81 into microsoft:main Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants