-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make adaptive expression library compatible with IE #2906
make adaptive expression library compatible with IE #2906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, can you verify that this bundle still works for your use case as well?
Yes, I did verify it with adaptive-designer. I had to add aliases for the same but it worked. These are the 3 changes I did : |
Sorry, by mistake i closed the PR. Have reopened it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for your work on this 👍
Thanks. Can we merge this ? |
"set-version": "npm version --allow-same-version ${Version}" | ||
}, | ||
"files": [ | ||
"src", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any benefit to us including "src"
? If someone wanted to use the "src"
, they should likely instead use adaptive-expressions
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks for pushing those changes
remove "src" from "files" entry
##Fixes:
Make adaptive expression library compatible with IE
Description
There was no support of IE in the adaptive expression library. Using babel to transpile compiled code and add polyfills so that it works in IE also.
Specific Changes
Testing
Tested manually by taking dependecy in adaptive card designer in IE to make sure that there are no errors