Only import lodash's sortBy method #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My goal here is to hopefully eventually reduce package sizes by restricting |
joshgummersall
suggested changes
Oct 2, 2020
| @@ -9,7 +9,7 @@ | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
| /* eslint-disable @typescript-eslint/explicit-module-boundary-types */ | |||
| import { Constant } from './constant'; | |||
| import * as lodash from 'lodash'; | |||
| import { sortBy as lodashSortBy } from 'lodash'; | |||
There was a problem hiding this comment.
I think this will be more effective: https://stackoverflow.com/questions/35250500/correct-way-to-import-lodash
Feel free to verify that this gives the expected package size reductions.
|
thanks everyone! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of
importing all oflodashinfunctionUtils.internal.ts, import only thesortBymethod, which is the only one needed.Testing
Already covered by existing
sortBytests (which pass).