Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] Fix error in parsing empty string in string interpolation #2748

Merged
merged 6 commits into from
Aug 31, 2020

Conversation

ShYuPe
Copy link
Contributor

@ShYuPe ShYuPe commented Aug 27, 2020

Port C# PR: microsoft/botbuilder-dotnet#4504

In adaptive expression, currently,

var parsed = Expression.parse("``");

will throw an error.
In this PR, the parser rule is changed so that, empty string in string interpolation can be correctly processed.

@ShYuPe ShYuPe requested review from stevengum and a team as code owners August 27, 2020 08:57
package.json Outdated Show resolved Hide resolved
@cosmicshuai cosmicshuai changed the title fix error in parsing empty string in string interpolation [Port] Fix error in parsing empty string in string interpolation Aug 28, 2020
@cosmicshuai cosmicshuai self-requested a review August 31, 2020 09:13
Copy link
Contributor

@cosmicshuai cosmicshuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@boydc2014 boydc2014 merged commit 8b7db50 into microsoft:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants