Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renaming of Task Response type #2369

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Fix renaming of Task Response type #2369

merged 2 commits into from
Jun 30, 2020

Conversation

ert485
Copy link
Contributor

@ert485 ert485 commented Jun 16, 2020 •
edited by axelsrz
Loading

fixes #2332

Description

'continue' should be a valid type for a TaskModuleResponseBase->type, but the types only allow 'edit' and 'send' (both of which fail)

#1789 incorrectly changed Type2 to BotMessagePreviewActionType instead of BotMessagePreviewType

Specific Changes

  • use BotMessagePreviewType where Type2 previously was used

@ert485
Fix renaming of Task Response type
be717eb 
microsoft#1789 incorrectly changed `Type2` to `BotMessagePreviewActionType` instead of `BotMessagePreviewType`
@ert485 ert485 requested a review from a team as a code owner June 16, 2020 21:03
@ert485 ert485 requested review from Stevenic and stevengum June 16, 2020 21:03
@stevengum stevengum merged commit 208c41c into microsoft:master Jun 30, 2020
@stevengum
Copy link
Member

stevengum commented Jun 30, 2020 •
edited
Loading

Thanks @ert485!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct Teams typings for TaskModuleResponses
3 participants
@ert485 @stevengum @EricDahlvang