Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QnA Maker] host name as-is #1999

Merged
merged 2 commits into from
Apr 8, 2020
Merged

[QnA Maker] host name as-is #1999

merged 2 commits into from
Apr 8, 2020

Conversation

vipeketi
Copy link
Contributor

@vipeketi vipeketi commented Apr 8, 2020 •
edited
Loading

Fixes #

Description

hostname cannot be partially hardcoded.

Specific Changes

QnAMakerDialog.ts has part of hostname hardcoded with recent checkin. The change has been reverted.
Related Sample PR : microsoft/BotBuilder-Samples#2306

Testing

All the tests have passed.

@vipeketi vipeketi requested a review from gurvsing April 8, 2020 14:02
@coveralls
Copy link

coveralls commented Apr 8, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 118461

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 66.947%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 118439: -0.08%
Covered Lines: 10233
Relevant Lines: 14463
💛 - Coveralls

@vipeketi vipeketi changed the title host name as-is [QnA Maker] host name as-is Apr 8, 2020
@vipeketi vipeketi mentioned this pull request Apr 8, 2020
Merged
@stevengum stevengum mentioned this pull request Apr 8, 2020
Closed
@vipeketi vipeketi merged commit bd2c4fd into master Apr 8, 2020
@vishwacsena vishwacsena deleted the vipeketi/fixhostname branch April 8, 2020 18:02
@stevengum stevengum mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somigithub somigithub somigithub approved these changes

@stevengum stevengum stevengum approved these changes

@gurvsing gurvsing Awaiting requested review from gurvsing

@vishwacsena vishwacsena Awaiting requested review from vishwacsena

@cleemullins cleemullins Awaiting requested review from cleemullins

Assignees
No one assigned
Labels
Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vipeketi @coveralls @stevengum @somigithub