Update BotState SaveChanges to implement CancellationToken #5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimercer
changed the title
joelsantos
approved these changes
Oct 18, 2021
EricDahlvang
approved these changes
Oct 18, 2021
|
@EricDahlvang, thanks for the approval! I don't have write access to be able to merge this pull request. If you're happy with it, do you mind merging it for me? |
gabog
added a commit
that referenced
this pull request
Oct 28, 2021
* Deprecate CosmosDbCustomClientOptions (#5910) * Deprecate CosmosDbCustomClientOptions * Add using for System to CosmosDbCustomClientOptions * New pipelines for the new vNextPrototype branch (#5912) * Set up vNextPrototype pipelines * Remove copy publish DLLs * Add skipComponentGovernanceDetection: true * Comment fix * Removed commented-out code * Upgrade AspNetCore.Mvc.NewtonsoftJson (#5916) * Streaming Library Refactor (#5908) * Fix build break. (#5918) * Fix build break. * Add icon.png to new streaming library. * Updaete BotState SaveChanges to implement CancellationToken (#5921) Thanks @nimercer * Update preview builds version (#5919) * fix comparison policy of string in adaptive expressions (#5925) * MSAL: Update to Microsoft.Identity.Client v4.37 to allow sendX5C configuration in bot startups (#5927) * Add */* accept header to ConnectorClient httpclient (#5926) * Add applicaiton/json accept header to ConnectorClient httpclient * Change application/json to */* for accept header Co-authored-by: Eric Dahlvang <erdahlva@microsoft.com> Co-authored-by: BruceHaley <v-brucehaley@microsoft.com> Co-authored-by: Muthuveer Somanathan <41929942+msomanathan@users.noreply.github.com> Co-authored-by: nimercer <48482128+nimercer@users.noreply.github.com> Co-authored-by: Monica Rivera <44449640+mrivera-ms@users.noreply.github.com> Co-authored-by: Hongyang Du (hond) <hond@microsoft.com> Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5920
Description
Currently BotState SaveChanges method ignores CancellationToken. This change passes the cancellation token on to the IStorage object, which already supports passing of Cancellation Token
Specific Changes
Testing