add null string support in StringUtils #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danieladu
requested review from
gabog,
johnataylor and
mrivera-ms
as code owners
Danieladu
changed the title
xieofxie
added a commit
to xieofxie/botbuilder-dotnet
that referenced
this pull request
Apr 29, 2020
StringUtils fixed in microsoft#3826
tomlm
reviewed
Apr 29, 2020
| @@ -32,6 +33,7 @@ public static string Ellipsis(string text, int length) | |||
| /// <returns>string which is unique SHA256 hash.</returns> | |||
| public static string Hash(string text) | |||
| { | |||
| text = text ?? string.Empty; | |||
There was a problem hiding this comment.
string.Empty [](start = 26, length = 13)
This should throw new ArgumentNullException(nameof(text)) #Resolved
cleemullins
pushed a commit
that referenced
this pull request
May 1, 2020
* create parity with OAuthPrompt * fix StringUtils fixed in #3826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #3825
Support
nullstring inEllipsisandHashmethod