Some cleanup of internals #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomlm
commented
Apr 9, 2020
tomlm
commented
- Add dialogComponentRegistration
- move memoryscope registration to dialogComponentRegistration
- fix pathResolvers to not be order depedent by checking char after alias is valid path
- rename context to sourceContext for sourcemap info to be clearer and to enable changes to sourceContext without introducing breaking changes
- made SourceRange internal
* move memoryscope registration to dialogComponentRegistration * fix pathResolvers to not be order depedent by checking char after alias is valid path * rename context to sourceContext for sourcemap info to be clearer. * made SourceRange internal
carlosscastro
approved these changes
Apr 9, 2020
| @@ -0,0 +1,24 @@ | |||
| using System; | |||
| /// </summary> | ||
| public class SourceContext | ||
| { | ||
| public SourceContext() |
There was a problem hiding this comment.
Any reason to keep the default constructor?
| /// <summary> | ||
| /// SourceContext used to build sourcemap of metadata about the call relationships between assets. | ||
| /// </summary> | ||
| public class SourceContext |
There was a problem hiding this comment.
This is a better parameter than the stack we were passing around, good call.
| @@ -0,0 +1,24 @@ | |||
| using System; | |||
willportnoy
approved these changes
Apr 9, 2020
This was referenced Apr 15, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.