This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Don't jsonencode kubeconfig on write #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmspring
approved these changes
Feb 21, 2019
samiyaakhtar
added a commit
that referenced
this pull request
Feb 26, 2019
* Add build.sh * Update .gitignore * make agent_vm_size explicit (#117) * Use better named and CI/CD generated fabrikate-cloud-native-manifests repo (#119) * GitOps documentation improvements (#121) Addressing various feedback on the GitOps documentation: * Improved documentation around personal access token generation * Support for private repo cloning in build.sh * Decoupled build.sh from repositories * Provided a new azure-pipelines.yaml sample * Don't jsonencode kubeconfig on write (#132) * Add Terratest automated testing for each commit (#131) * Travis initialized for Bedrock go testing using terratest * Adding travis status emblem in readme * Quote kubeconfig to prevent certain shells treating it as multiple arguments (#133) * Revert "Merge branch 'master' into master" This reverts commit 13329b9, reversing changes made to ca52838.
samiyaakhtar
added a commit
that referenced
this pull request
Feb 28, 2019
* Initial commit or documentation * Added shell script used in Azure Pipelines build (#53) * Add build.sh * Update .gitignore * Parameterized AKS Manifest Repo * Added error handling and minor bug fix, with README (#54) * Added error handling and minor bug fix, with README * Update name of script * resolved issue with Jaeger integration via Fabrikate (#55) * resolved issue with jaeger integration via Fabrikate helm initlization and incubator url needs to be added before running 'fab install' * Parameterized helm repo url * added defaults for helm * Update build.sh * Update build.sh * Initial commit or documentation (#58) * helm default repo and repo url will be used when helm variables are not specified (#59) * PR verification and break down of shell script (#72) * PR verification and break down of shell script * Adding checks for OS type * Change darwin18 to darwin as per fab releases * Documentation updates * Added unit test content (prototype) (#78) * Added unit test content * Documentation updates * Initial documentation for gitops area (#82) * Documentation updates * Fail on fab errors (#84) * Initial commit or documentation * Cluster creation README.md clean up modifications (#85) * azure blob store for state. adds support for #22 (#75) * Closes #65 that adds support for Azure DevOps git repos in flux until it natively supports with a outcome of #81 (#87) * Refactor Terraform (#93) * Refactors Terraform to use a more modular structure. * Feature: Ability to independently enable/disable and trigger kube config to disk * Feature: Ability to independently enable/disable and trigger flux deployment * Feature: Enable AKS virtual node addon by specifying `enable_virtual_node_addon="true"` Fixes Issue #83 Fixes issue #80 * Azure DevOps documentation (#98) * Initial commit or documentation * Support for Azure DevOps repos (#91) * Added support for Azure DevOps repo * Gitops doc changes (#106) * Update README.md * Update AzureDevOpsGit.md * Documentation updates (#108) * Various documentation changes * Changes to test PR * Added shell script used in Azure Pipelines build (#53) * Add build.sh * Update .gitignore * Parameterized AKS Manifest Repo * Added error handling and minor bug fix, with README (#54) * Added error handling and minor bug fix, with README * Update name of script * resolved issue with Jaeger integration via Fabrikate (#55) * resolved issue with jaeger integration via Fabrikate helm initlization and incubator url needs to be added before running 'fab install' * Parameterized helm repo url * added defaults for helm * Update build.sh * Update build.sh * Initial commit or documentation (#58) * helm default repo and repo url will be used when helm variables are not specified (#59) * PR verification and break down of shell script (#72) * PR verification and break down of shell script * Adding checks for OS type * Change darwin18 to darwin as per fab releases * Added unit test content (prototype) (#78) * Added unit test content * Initial documentation for gitops area (#82) * Documentation updates * Fail on fab errors (#84) * Azure DevOps documentation (#98) * Initial commit or documentation * Support for Azure DevOps repos (#91) * Added support for Azure DevOps repo * Gitops doc changes (#106) * Update README.md * Update AzureDevOpsGit.md * Documentation updates (#108) * Various documentation changes * Update README.md * Update GettingStarted.md * Updates to documentation based on feedback (#110) * More documentation changes * SVG chang * Added png version * Update README.md * Tweaks * Merging from master into services * Merging from master into services * Documentation updates * Removing file * Removing file * Merging from master * Fixes to missing links in documentation. Updated documentation and build script (#115) * Documentation updates. Build script changes. * More changes * Updates * Changes * Updated image and doc. Removed git_type check * GitOps documentation updates (#120) * Improved GitHub and AzDevOps repo creation instructions * Renamed AKS_MANIFEST_REPOS to MANIFEST_REPOS * Enabled private repository cloning (closes #118) * Kubediff deployment (#143) * make agent_vm_size explicit (#117) * make agent_vm_size explicit (#117) * First pass of kubediff terraform scripts * Fixed regex sed command * Kubediff deployment working as part of terraform * Move kubediff deployment to azure-simple and delete aks-flux-kubediff * make agent_vm_size explicit (#117) * get context before creating namespace * Update the location in repo of yaml files * Minor changes * Remove agent_vm_size * Remove unnecessary code * Bringing services up-to-date with master (#146) * Add build.sh * Update .gitignore * make agent_vm_size explicit (#117) * Use better named and CI/CD generated fabrikate-cloud-native-manifests repo (#119) * GitOps documentation improvements (#121) Addressing various feedback on the GitOps documentation: * Improved documentation around personal access token generation * Support for private repo cloning in build.sh * Decoupled build.sh from repositories * Provided a new azure-pipelines.yaml sample * Don't jsonencode kubeconfig on write (#132) * Add Terratest automated testing for each commit (#131) * Travis initialized for Bedrock go testing using terratest * Adding travis status emblem in readme * Quote kubeconfig to prevent certain shells treating it as multiple arguments (#133) * Revert "Merge branch 'master' into master" This reverts commit 13329b9, reversing changes made to ca52838. * Testing kubediff deployment (#147) * First pass of testing kubediff deployment with integration test * A little more verbose testing and printing the results of the verification * Make creation of namespace idempotent (#148)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #130