Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change code QL default settings file name #8118

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

nicogbg
Copy link
Contributor

@nicogbg nicogbg commented Feb 27, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

just rename CodeQL default setting file to match new recommendation

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@nicogbg nicogbg requested a review from a team as a code owner February 27, 2024 21:23
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Feb 27, 2024
@nicogbg nicogbg merged commit 2b8d95a into main Feb 27, 2024
9 checks passed
@nicogbg nicogbg deleted the nicogbg/CodeQL-disable-by-default branch February 27, 2024 22:08
nicogbg added a commit that referenced this pull request Feb 28, 2024
Co-authored-by: CBL-Mariner Servicing Account <cblmargh@microsoft.com>
SeanDougherty pushed a commit that referenced this pull request Mar 1, 2024
Co-authored-by: CBL-Mariner Servicing Account <cblmargh@microsoft.com>
nicogbg added a commit that referenced this pull request Mar 7, 2024
Co-authored-by: CBL-Mariner Servicing Account <cblmargh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants