Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch CVE-2024-24806 in nodejs18 #8110

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

suresh-thelkar
Copy link
Contributor

@suresh-thelkar suresh-thelkar commented Feb 27, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Patch CVE-2024-24806 in nodejs18

Change Log
  • CVE-2024-24806
Does this affect the toolchain?

NO

Associated issues
  • NA
Links to CVEs
Test Methodology
  • Unified buddy build results are here

@suresh-thelkar suresh-thelkar marked this pull request as ready for review February 27, 2024 08:32
@suresh-thelkar suresh-thelkar requested a review from a team as a code owner February 27, 2024 08:32
Copy link
Contributor

@kanikanema kanikanema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suresh-thelkar
Copy link
Contributor Author

LGTM

Thanks for the review.

Copy link
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline PR check build currently broken due to infrastructure issues - overriding. Relying on buddy and local builds.

@PawelWMS PawelWMS merged commit ae70b92 into fasttrack/2.0 Feb 28, 2024
10 of 13 checks passed
@PawelWMS PawelWMS deleted the sthelkar/nodejs18_fasttrack branch February 28, 2024 22:28
CBL-Mariner-Bot pushed a commit that referenced this pull request Feb 28, 2024
Co-authored-by: Suresh Thelkar <sthelkar@microsoft.com>
(cherry picked from commit ae70b92)
@CBL-Mariner-Bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants