Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: re-enable libsanitizer #8089

Merged
merged 1 commit into from
Feb 28, 2024
Merged

gcc: re-enable libsanitizer #8089

merged 1 commit into from
Feb 28, 2024

Conversation

anphel31
Copy link
Member

@anphel31 anphel31 commented Feb 26, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Re-enable thread sanitizer in gcc

Change Log
  • Re-enable thread sanitizer in gcc.spec
  • Add patch to fix build break:
time="2024-02-26T20:17:25UTC" ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory
time="2024-02-26T20:17:25UTC"   180 | #include <crypt.h>
time="2024-02-26T20:17:25UTC"       |          ^~~~~~~~~
time="2024-02-26T20:17:25UTC" compilation terminated.
time="2024-02-26T20:17:25UTC" make[4]: *** [Makefile:618: sanitizer_platform_limits_posix.lo] Error 1
Does this affect the toolchain?

YES

Associated issues
Links to CVEs
Test Methodology

@anphel31 anphel31 marked this pull request as ready for review February 27, 2024 02:38
@anphel31 anphel31 requested review from a team as code owners February 27, 2024 02:38
@anphel31 anphel31 merged commit 0e84a68 into 3.0-dev Feb 28, 2024
10 checks passed
@anphel31 anphel31 deleted the anphel/3-gcc-libsanitizer branch February 28, 2024 00:17
BettyRain pushed a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants