Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] virtiofsd: enable build on all supported platforms #7921

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Feb 16, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Build for ARM64 failed due to virtiofsd not compiled on ARM architecture.
Drop ExclusiveArch: x86_64 to enable build on all supported platforms

Change Log
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
  • NA
Test Methodology

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Feb 16, 2024
@mfrw mfrw requested a review from sprt February 16, 2024 09:50
@mfrw mfrw changed the title virtiofsd: enable build on all supported platforms [RFC] virtiofsd: enable build on all supported platforms Feb 16, 2024
@mfrw mfrw added the RFC Request For Comments label Feb 16, 2024
@mfrw mfrw marked this pull request as ready for review February 16, 2024 09:51
@mfrw mfrw requested a review from a team as a code owner February 16, 2024 09:51
@sprt
Copy link
Contributor

sprt commented Feb 16, 2024

LGTM, the ExclusiveArch was a remnant of the Fedora spec that I missed

@sprt sprt merged commit b65c546 into main Feb 16, 2024
11 checks passed
@sprt sprt deleted the mfrw/enable-virtiofsd-arm branch February 16, 2024 14:54
@mfrw
Copy link
Member Author

mfrw commented Feb 16, 2024

We had to revert the change original change in 2.0:

SeanDougherty pushed a commit that referenced this pull request Mar 1, 2024
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main RFC Request For Comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants