Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osslsigncode package #7868

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Add osslsigncode package #7868

merged 3 commits into from
Feb 15, 2024

Conversation

Camelron
Copy link
Contributor

@Camelron Camelron commented Feb 13, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

osslsigncode is a utility that implements part of the functionality of the Microsoft tool signtool.exe - more exactly the Authenticode signing and timestamping. But osslsigncode is based on OpenSSL and cURL. It can sign and timestamp PE (EXE/SYS/DLL/etc), CAB, CAT and MSI files, as well as signature verification, removal and extraction.

Change Log
  • Introduce osslsigncode
Does this affect the toolchain?

NO

Test Methodology

@Camelron Camelron requested review from a team as code owners February 13, 2024 23:29
@Camelron Camelron changed the base branch from 2.0 to main February 13, 2024 23:30
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Feb 13, 2024
@dallasd1
Copy link
Contributor

[nit] would it be possible to link the signing pipeline in the description? @ms-mahuber do you have any thoughts on aligning the PR title to keep release notes consistent?

@Camelron Camelron changed the title [ConfPods] [binary signing] Introduce osslsigncode Add osslsigncode package Feb 15, 2024
@Camelron Camelron merged commit 0fb82a0 into main Feb 15, 2024
11 checks passed
@Camelron Camelron deleted the cameronbaird/osslsigncode branch February 15, 2024 22:37
Camelron added a commit that referenced this pull request Feb 15, 2024
SeanDougherty pushed a commit that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants