Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add golden containers src artifacts #7664

Merged
merged 64 commits into from
Feb 23, 2024

Conversation

mandeepsplaha
Copy link
Contributor

@mandeepsplaha mandeepsplaha commented Feb 3, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

DEV Flow

AMD64
Base Container Build - [AMD64-3-OneBranch]-Dev-BuildImages
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501401&view=results
Golden Container Build - [AMD64-4-OneBranch]-Dev-BuildGoldenContainers
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501435&view=results
Test Base Container - AMD64-BaseContainerTests-DEV
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501436&view=results
Test Golden Containers - AMD64-GoldenContainerTests-DEV
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501466&view=results

ARM64
Base Container Build - [ARM64-3-OneBranch]-Dev-BuildImages
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501400&view=results
Golden Container Build - [ARM64-4-OneBranch]-Dev-BuildGoldenContainers
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501428&view=results
Test Base Container - ARM64-BaseContainerTests-DEV
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501429&view=results
Test Golden Containers - ARM64-GoldenContainerTests-DEV
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501477&view=results

Publish Base Containers - [NoArch-OneBranch]-Dev-PublishBaseContainers
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501481&view=results

Publish Golden Containers - [NoArch-OneBranch]-Dev-PublishGoldenContainers
- https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501482&view=results

@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Feb 3, 2024
@mandeepsplaha mandeepsplaha marked this pull request as ready for review February 8, 2024 01:45
@mandeepsplaha mandeepsplaha requested a review from a team as a code owner February 8, 2024 01:45
# instead of fetching from PMC
RUN if [ "${RPMS}" ]; then \
mkdir -p $LOCAL_REPO_PATH; \
tdnf install -y --releasever=2.0 createrepo; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey can we grab this at the next update swap the 2.0 for the variable

@mandeepsplaha mandeepsplaha merged commit f506a29 into main Feb 23, 2024
11 checks passed
@mandeepsplaha mandeepsplaha deleted the mandeepsplaha/add-container-src-artifacts branch February 23, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants