Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables: Enable nftables #10786

Merged
merged 2 commits into from
Oct 21, 2024
Merged

iptables: Enable nftables #10786

merged 2 commits into from
Oct 21, 2024

Conversation

Sumynwa
Copy link
Contributor

@Sumynwa Sumynwa commented Oct 18, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Enable building iptables with nftables to provide both iptables-legacy & iptables-nft with default being set to legacy.
This PR fixes https://microsoft.visualstudio.com/OS/_workitems/edit/53647336.

Change Log
  • Enable build with nftables
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology

@Sumynwa Sumynwa marked this pull request as ready for review October 21, 2024 10:44
@Sumynwa Sumynwa requested a review from a team as a code owner October 21, 2024 10:44
@Sumynwa Sumynwa added the 3.0-dev PRs Destined for AzureLinux 3.0 label Oct 21, 2024

%install
%make_install
ln -sfv ../../sbin/xtables-multi %{buildroot}%{_libdir}/iptables-xml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path xtables-multi does not exist and this becomes stale link. The correct path is added later in the commit (iptables.spec: L67)

@mfrw mfrw added the stable-release-shiproom PRs for consideration for stable shiproom label Oct 21, 2024
@Sumynwa Sumynwa merged commit 301637a into 3.0-dev Oct 21, 2024
12 checks passed
@Sumynwa Sumynwa deleted the sumsharma/iptables-nft branch October 21, 2024 17:39
christopherco added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging stable-release-shiproom PRs for consideration for stable shiproom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants