Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy entire build output before publish #25518

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Copy entire build output before publish #25518

merged 4 commits into from
Aug 27, 2024

Conversation

zijchen
Copy link
Member

@zijchen zijchen commented Mar 19, 2024

Address #25517

Recent change in DacFx removed full paths of references from build output. Because ADS copies the dacpac to a temp location before publish (due to a locking issue #11036), this is causing the referenced dacpac to not be found. Fix is to copy the entire output folder which should contain all the necessary references.

@coveralls
Copy link

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 10586167192

Details

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 41.72%

Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/sql-database-projects/src/controllers/projectController.ts 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
extensions/sql-database-projects/src/common/httpClient.ts 1 66.18%
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 45.22%
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts 2 52.03%
Totals Coverage Status
Change from base Build 10572064744: -0.005%
Covered Lines: 30727
Relevant Lines: 68921

💛 - Coveralls

Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the extension version as well

@kburtram
Copy link
Member

@zijchen is this change still planned or should this be closed as abandoned?

@zijchen
Copy link
Member Author

zijchen commented Aug 27, 2024

@zijchen is this change still planned or should this be closed as abandoned?

We decided to revert the change in DacFx which was why I left this PR idle, but I think it's still good to have because there could be other artifacts the dacpac requires and expects in the same folder. I'll merge it.

@zijchen zijchen merged commit 570c27b into main Aug 27, 2024
12 checks passed
@zijchen zijchen deleted the zijchen/issue25517 branch August 27, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants