-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy entire build output before publish #25518
Conversation
Pull Request Test Coverage Report for Build 10586167192Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update the extension version as well
@zijchen is this change still planned or should this be closed as abandoned? |
We decided to revert the change in DacFx which was why I left this PR idle, but I think it's still good to have because there could be other artifacts the dacpac requires and expects in the same folder. I'll merge it. |
Address #25517
Recent change in DacFx removed full paths of references from build output. Because ADS copies the dacpac to a temp location before publish (due to a locking issue #11036), this is causing the referenced dacpac to not be found. Fix is to copy the entire output folder which should contain all the necessary references.