Add vscode support for System database package references for SDK-style sql projects #23383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisantia
commented
Jun 13, 2023
| @@ -1112,7 +1113,7 @@ declare module 'vscode-mssql' { | |||
| packageFilePath: string; | |||
| databaseName: string; | |||
| upgradeExisting: boolean; | |||
| sqlCommandVariableValues?: Map<string, string>; | |||
| sqlCommandVariableValues?: Record<string, string>; | |||
There was a problem hiding this comment.
I copied over the state of the file in main in the vscode-mssql repo so that they're synced up, so there are a few changes like this one made in microsoft/vscode-mssql#17683, that hadn't made over to the ADS copy of the file.
Benjin
reviewed
Jun 14, 2023
extensions/sql-database-projects/src/dialogs/addDatabaseReferenceQuickpick.ts
Show resolved
Hide resolved
extensions/sql-database-projects/src/dialogs/addDatabaseReferenceQuickpick.ts
Outdated
Show resolved
Hide resolved
| @@ -1112,7 +1113,7 @@ declare module 'vscode-mssql' { | |||
| packageFilePath: string; | |||
| databaseName: string; | |||
| upgradeExisting: boolean; | |||
| sqlCommandVariableValues?: Map<string, string>; | |||
| sqlCommandVariableValues?: Record<string, string>; | |||
Benjin
approved these changes
Jun 14, 2023
kavitham10
pushed a commit
that referenced
this pull request
Jun 15, 2023
…le sql projects (#23383) * changes for supporting system db package references in vscode * cleanup * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for system database package references for SDK-style projects in the sql projects vscode extension, now that the system database nuget packages are available:
New quickpick step to choose between
PackageReferenceandArtifactReference. This only shows up for SDK-style projects, not legacy projects.Adding a system db ref as a PackageReference, followed by adding one as an ArtifactReference:
https://github.com/microsoft/azuredatastudio/assets/31145923/194cf0db-b46d-4a43-82e5-f45d1cba0a5b