Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mac signing #18534

Merged
merged 5 commits into from
Feb 23, 2022
Merged

Fix Mac signing #18534

merged 5 commits into from
Feb 23, 2022

Conversation

Charles-Gagnon
Copy link
Contributor

.NET 2.1 is being removed from all hosted agents

actions/runner-images#4871

This is currently required for the signing task and so install it manually for now until the signing task can be updated to not require 2.1. Note that this is only required for Macs though - the other OSes have been updated to use .NET 6 per https://marketplace.visualstudio.com/items?itemName=SFP.build-tasks&targetId=465e99f0-a0f9-4257-95e0-04c716327b00

11/29/2021 (CodeSign task v1.9.101, ScanTask v1.6.90)

Add .net core 6 support (not include Mac OS)

@coveralls
Copy link

coveralls commented Feb 23, 2022

Pull Request Test Coverage Report for Build 1888106046

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.28%

Totals Coverage Status
Change from base Build 1888099844: 0.0%
Covered Lines: 14819
Relevant Lines: 29137

💛 - Coveralls

@Charles-Gagnon Charles-Gagnon merged commit 23cbb98 into main Feb 23, 2022
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/installNetSdkSigning branch February 23, 2022 16:31
Charles-Gagnon added a commit that referenced this pull request Feb 23, 2022
* Install .NET SDK for Mac signing

* Install runtime

* Specify 2.1.0

* Install SDK

(cherry picked from commit 23cbb98)
Charles-Gagnon added a commit that referenced this pull request Feb 23, 2022
* Install .NET SDK for Mac signing

* Install runtime

* Specify 2.1.0

* Install SDK

(cherry picked from commit 23cbb98)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants