Fix ssl config issue

microsoft · Nov 1, 2019 · cacd481 · cacd481
1 parent 650ab3b
commit cacd481
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/extensions/big-data-cluster/src/bigDataCluster/utils.ts b/extensions/big-data-cluster/src/bigDataCluster/utils.ts
@@ -281,7 +281,8 @@ export const ignoreSslConfigName = 'ignoreSslVerification';
 export function getIgnoreSslVerificationConfigSetting(): boolean {
 	try {
 		const config = vscode.workspace.getConfiguration(bdcConfigSectionName);
-		return config.get<boolean>(ignoreSslConfigName) || true;
+		const value = config.get<boolean>(ignoreSslConfigName);
+		return value !== undefined ? value : true;
 	} catch (error) {
 		console.error(`Unexpected error retrieving ${bdcConfigSectionName}.${ignoreSslConfigName} setting : ${error}`);
 	}

diff --git a/extensions/mssql/src/util/auth.ts b/extensions/mssql/src/util/auth.ts
@@ -28,7 +28,8 @@ const ignoreSslConfigName = 'ignoreSslVerification';
 export function getIgnoreSslVerificationConfigSetting(): boolean {
 	try {
 		const config = vscode.workspace.getConfiguration(bdcConfigSectionName);
-		return config.get<boolean>(ignoreSslConfigName) || true;
+		const value = config.get<boolean>(ignoreSslConfigName);
+		return value !== undefined ? value : true;
 	} catch (error) {
 		console.error(`Unexpected error retrieving ${bdcConfigSectionName}.${ignoreSslConfigName} setting : ${error}`);
 	}

diff --git a/extensions/notebook/src/common/utils.ts b/extensions/notebook/src/common/utils.ts
@@ -256,7 +256,8 @@ const ignoreSslConfigName = 'ignoreSslVerification';
 export function getIgnoreSslVerificationConfigSetting(): boolean {
 	try {
 		const config = vscode.workspace.getConfiguration(bdcConfigSectionName);
-		return config.get<boolean>(ignoreSslConfigName) || true;
+		const value = config.get<boolean>(ignoreSslConfigName);
+		return value !== undefined ? value : true;
 	} catch (error) {
 		console.error(`Unexpected error retrieving ${bdcConfigSectionName}.${ignoreSslConfigName} setting : ${error}`);
 	}