Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Use vscode.env.openExternal to open browser windows when available #498

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

Chuxel
Copy link
Member

@Chuxel Chuxel commented Mar 14, 2019

This PR uses the reliable vscode.env.openExternal to open browser windows on versions of VS Code that support it. It keeps the old node modules in place as a fallback to support older versions.

Copy link
Member

@jrbriggs jrbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jrbriggs jrbriggs merged commit 2908ec8 into microsoft:master Mar 14, 2019
@JVVickery
Copy link

#490

I believe I need #490 to activate my extension, but so far I haven't had much luck.

heySkidz pushed a commit to heySkidz/azure-repos-vscode that referenced this pull request Sep 16, 2019
… to open browser windows when available"

This reverts commit 2908ec8, reversing
changes made to f76a76f.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants