This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add ability to include/exclude changes #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also provided Refresh in context menu Removed ExcludeAll/IncludeAll
jpricket
reviewed
Feb 13, 2017
src/extension.ts
Outdated
| context.subscriptions.push(commands.registerCommand(TfvcCommandNames.IncludeAll, () => _extensionManager.Tfvc.TfvcIncludeAll())); | ||
| })); | ||
| context.subscriptions.push(commands.registerCommand(TfvcCommandNames.Exclude, (...args) => { | ||
| if (args) { |
There was a problem hiding this comment.
Since most commands will need this logic, it would be nice to somehow push this into a helper method. Not sure if that is easy or not.
jpricket
reviewed
Feb 13, 2017
src/tfvc/commands/add.ts
Outdated
| let line: string = lines[index]; | ||
| if (this.isFilePath(line)) { | ||
| path = line; | ||
| } else if (line) { |
There was a problem hiding this comment.
line can't be empty here since you excluded them in the split above.
jpricket
reviewed
Feb 13, 2017
src/tfvc/tfvc-extension.ts
Outdated
| //At this point, an unversioned file could be a candidate file, so call Add. Once it is added, it should be a Pending change. | ||
| if (!resource.IsVersioned) { | ||
| await this._repo.Add([path]); | ||
| //Even if adding a file, Unexclude it (it may have been excluded previously) |
There was a problem hiding this comment.
The comments are a bit confusing. Looks like you used to have an else clause here and then removed it.
jpricket
reviewed
Feb 13, 2017
src/tfvc/tfvcscmprovider.ts
Outdated
| }; | ||
|
|
||
| public static async Refresh(): Promise<void> { | ||
| const tfvcProvider: TfvcSCMProvider = TfvcSCMProvider.instance; |
There was a problem hiding this comment.
looks like we are reusing this invalid state check a lot. Consider refactoring it into it's own method that gets the scm provider.
jpricket
reviewed
Feb 13, 2017
src/tfvc/scm/model.ts
Outdated
| //Add the item to the explicitly excluded list. | ||
| public async Exclude(path: string): Promise<void> { | ||
| if (path) { | ||
| if (!_.contains(this._explicitlyExcluded, path)) { |
There was a problem hiding this comment.
Is this contains case insensitive? It probably should be.
jpricket
reviewed
Feb 13, 2017
src/tfvc/scm/model.ts
Outdated
| //Unexclude doesn't explicitly INclude. It defers to the status of the individual item. | ||
| public async Unexclude(path: string): Promise<void> { | ||
| if (path) { | ||
| if (_.contains(this._explicitlyExcluded, path)) { |
jpricket
approved these changes
Feb 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also provided Refresh in context menu
Removed ExcludeAll/IncludeAll