Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deploy to K8s] Clean up #158

Merged
merged 6 commits into from
Apr 4, 2019
Merged

Conversation

thesattiraju
Copy link
Contributor

In this PR

  1. Unused variables are removed
  2. Using single quotes everywhere instead of double in this template
  3. Updated the task usage to sync with the task changes here [KubernetesManifestV0] updating action name azure-pipelines-tasks#10029

templates/deploy-to-existing-k8s.yml Outdated Show resolved Hide resolved
templates/deploy-to-existing-k8s.yml Outdated Show resolved Hide resolved
templates/deploy-to-existing-k8s.yml Outdated Show resolved Hide resolved
templates/deploy-to-existing-k8s.yml Outdated Show resolved Hide resolved
@thesattiraju thesattiraju dismissed shashankbarsin’s stale review April 4, 2019 07:27

Changes suggested have been incorporated

@thesattiraju thesattiraju merged commit d5506d4 into master Apr 4, 2019
@thesattiraju thesattiraju deleted the users/desattir/templateFixes branch April 4, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants