Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposals/pipeline caching #113
Proposals/pipeline caching #113
Changes from all commits
f4a3d8f
4002d9c
2ee6766
63e10f4
23d440f
3ddb4e1
f265c7e
3bdf550
35e162a
84478fa
300fcc0
44f3eda
fd0dba2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitchdenny Are we missing a
path
keyword here? I thought that the caching service wasn't able to save off the relative path. (It would be great if we don't have to make the user say it twice! But I don't recall us solving that problem yet.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No its not solved yet - good catch. I'll push an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to say "key" here or can we mirror the
restoreCache
model of just putting the key aftersaveCache
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be possible (and sometimes necessary) to interleave multiple cache restore and save operations. For example:
Its a bit contrived but you can probably see how sometimes people will interleave caches (especially if caches are related and interdependent).
That said - maybe there is a simple scenario that we can optimize here. I recall when we caught up in NC that you mentioned that there could be a way of doing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I follow. I was asking a syntactic question about whether
key
has to live as a separate input vs if it could just go aftersaveCache
. Given that you did it in your example, I think your answer is yes? 😛Regarding the
path
stuff -- you can't have duplicatepath
keys. You have two options: (1) makepath
take either a string or an array of strings or (2) take only a string, and in the task, expect a newline-delimited list.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen if in V1 of the task we converted the type to string[]? The YAML ends up being the same doesn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the ability to say "take a scalar or an array". But if you choose just one in the schema, then your YAML is limited to that one. Does that make sense?