Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to overwrite files in target for extract7z function #153

Conversation

EzzhevNikita
Copy link
Contributor

@EzzhevNikita EzzhevNikita commented Mar 21, 2022

Added option to overwrite files in destination catalog during files extraction in extract7z function.
Function tested with NodeToolV0 task.

Related issue: #66

@EzzhevNikita EzzhevNikita changed the title Add option to overwrite files in target Add option to overwrite files in target for extract7z function Mar 22, 2022
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tool.ts Outdated Show resolved Hide resolved
tool.ts Outdated Show resolved Hide resolved
@anatolybolshakov
Copy link
Contributor

LGTM, thanks! Please take a look at comments also

Copy link

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and please take a look at the suggestions below

tool.ts Outdated Show resolved Hide resolved
tool.ts Outdated Show resolved Hide resolved
@EzzhevNikita
Copy link
Contributor Author

@mmrazik Could you please take a look at this PR?

@mmrazik mmrazik merged commit 426ba81 into microsoft:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants