Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify what's expected for the known_hosts entry #9973

Merged
merged 3 commits into from
Mar 29, 2019

Conversation

vtbassmatt
Copy link
Member

fixes #8950

@vtbassmatt vtbassmatt requested a review from madhurig as a code owner March 29, 2019 12:14
@madhurig madhurig requested a review from lkillgore March 29, 2019 12:17
Copy link
Contributor

@madhurig madhurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version of task in task.json

fixes #8950 (by making the correct input more clear)
@vtbassmatt vtbassmatt force-pushed the installssh-known-hosts branch from 42ff4de to 5a703aa Compare March 29, 2019 14:49
@vtbassmatt
Copy link
Member Author

@lkillgore -- Madhuri approved before I completely changed tack here, so I don't want to complete this without you taking another quick look.

Copy link
Contributor

@lkillgore lkillgore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vtbassmatt vtbassmatt merged commit 4600449 into master Mar 29, 2019
@vtbassmatt vtbassmatt deleted the installssh-known-hosts branch March 29, 2019 18:04
@vtbassmatt vtbassmatt changed the title include public key in known_hosts entry clarify what's expected for the known_hosts entry Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install SSH key doesn't add the public SSH to the known_hosts
3 participants