Azure App Service - add message for expired service principal #9972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
added
Area: Release
Area: AzureAppService
vincent1173
commented
Mar 29, 2019
| else | ||
| { | ||
| else if(response.statusCode == 401) { | ||
| deferred.reject(tl.loc('ExpiredServicePrincipal')); |
There was a problem hiding this comment.
currently not adding Service connection name / link. That requires a major change and will add based on customer asks.
SumiranAgg
approved these changes
Mar 29, 2019
Will do it. Problem is I need to patch all the task versions that consumes that common module. |
vincent1173
requested review from
bansalaseem,
kasubram,
Lovakumar,
madhurig,
RoshanKumarMicrosoft and
sachinma
as code owners
bansalaseem
approved these changes
Apr 10, 2019
sachinma
reviewed
Apr 10, 2019
kmkumaran
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide recommendation mesaage when SPN is invalid or expired.