DockerV2 - Fixing some issues/feeback. #9927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajinkya599
commented
Mar 26, 2019
ajinkya599
commented
- Use Rename input from dockerFile to Dockerfile
- Ignore arguments input for buildAndPush and create warning instead of failing the task
- Fix the code to restore earlier login and some debug statements.
bansalaseem
reviewed
Mar 26, 2019
ajinkya599
force-pushed
the
users/aj/dockerV2-fixes
branch
2 times, most recently
from
1659732 to
e838021
Compare
bansalaseem
approved these changes
Mar 29, 2019
ajinkya599
force-pushed
the
users/aj/dockerV2-fixes
branch
2 times, most recently
from
b88a368 to
4d09a9f
Compare
- Use Rename input from dockerFile to Dockerfile - Ignore arguments input for buildAndPush and create warning instead of failing the task - Fix the code to restore earlier login and some debug statements.
…, DockerV0, DockerV1, KubernetesV0, KubernetesV1
ajinkya599
force-pushed
the
users/aj/dockerV2-fixes
branch
from
4d09a9f to
4a945fc
Compare
ajinkya599
added a commit
that referenced
this pull request
Apr 1, 2019
* DockerV2 - Fixing some issues/feeback: - Use Rename input from dockerFile to Dockerfile - Ignore arguments input for buildAndPush and create warning instead of failing the task - Fix the code to restore earlier login and some debug statements. * Bumping up task versions as imposed by build policy - DockerComposeV0, DockerV0, DockerV1, KubernetesV0, KubernetesV1
ajinkya599
added a commit
that referenced
this pull request
Apr 1, 2019
* DockerV2 - Fixing some issues/feeback: - Use Rename input from dockerFile to Dockerfile - Ignore arguments input for buildAndPush and create warning instead of failing the task - Fix the code to restore earlier login and some debug statements. * Bumping up task versions as imposed by build policy - DockerComposeV0, DockerV0, DockerV1, KubernetesV0, KubernetesV1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.