Users/yacao/ftpuploadv2 #9920
Merged
Users/yacao/ftpuploadv2 #9920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkillgore
reviewed
Mar 25, 2019
Tasks/FtpUploadV2/ftpuploadtask.ts
Outdated
| trustSSL: boolean; | ||
| } | ||
|
|
||
| class ProgressTracking { |
There was a problem hiding this comment.
Is there any reason why visibility markers aren't here? e.g. public and private for the method names and the member variables?
There was a problem hiding this comment.
Yeah, it should have one. I merged this from another file before, forgot to add a qualifier.
There was a problem hiding this comment.
I can't add any modifier, it complains
'private' modifier cannot appear on a module or namespace element.ts(1044)
so I think this is fine, it's not exported anyway.
lkillgore
reviewed
Mar 25, 2019
lkillgore
reviewed
Mar 25, 2019
lkillgore
reviewed
Mar 25, 2019
lkillgore
reviewed
Mar 25, 2019
lkillgore
reviewed
Mar 25, 2019
lkillgore
reviewed
Mar 25, 2019
Tasks/FtpUploadV2/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
lkillgore
reviewed
Mar 25, 2019
lkillgore
reviewed
Mar 25, 2019
lkillgore
reviewed
Mar 25, 2019
lkillgore
approved these changes
Mar 25, 2019
pjquirk
reviewed
Mar 25, 2019
brcrista
reviewed
Mar 25, 2019
brcrista
reviewed
Mar 25, 2019
brcrista
reviewed
Mar 25, 2019
brcrista
reviewed
Mar 25, 2019
brcrista
reviewed
Mar 30, 2019
brcrista
reviewed
Mar 30, 2019
brcrista
reviewed
Mar 30, 2019
brcrista
reviewed
Mar 30, 2019
brcrista
reviewed
Mar 30, 2019
brcrista
reviewed
Mar 30, 2019
brcrista
reviewed
Apr 1, 2019
brcrista
reviewed
Apr 1, 2019
Tasks/FtpUploadV2/ftpuploadtask.ts
Outdated
| // other standard options | ||
| rootFolder: tl.getPathInput("rootFolder", true), | ||
| filePatterns: tl.getDelimitedInput("filePatterns", "\n", true), | ||
| remotePath: tl .getInput("remotePath", true).trim().replace(/\\/gi, "/"), // use forward slashes alway |
There was a problem hiding this comment.
nit: typo, and extra space before .getInput
brcrista
approved these changes
Apr 1, 2019
|
Build canary is also updated with v2 of task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update FtpUpload tasks with different ftp library, azure-pipelines-tasks-lib, and add retry logic.