[KubernetesManifestV0] Promote and Reject actions added #9914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nishubansal could you add some L0s? |
Tasks/KubernetesManifestV0/Strings/resources.resjson/en-US/resources.resjson
Show resolved
Hide resolved
added 2 commits
March 26, 2019 18:38
|
You need to bump up the version of all the tasks which take a dependency on common. New check I suppose. That's breaking your CI build. |
nishubansal
requested review from
jotaylo,
kmkumaran,
madhurig,
prativen,
RoshanKumarMicrosoft,
sachinma and
vithati
as code owners
shashankbarsin
suggested changes
Mar 30, 2019
Tasks/KubernetesManifestV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
added 6 commits
April 1, 2019 10:19
shashankbarsin
approved these changes
Apr 1, 2019
thesattiraju
pushed a commit
that referenced
this pull request
Apr 4, 2019
…teAction [KubernetesManifestV0] Promote and Reject actions added
thesattiraju
added a commit
that referenced
this pull request
Apr 4, 2019
* Merge pull request #9914 from Microsoft/users/nibansal/KubernetesDeleteAction [KubernetesManifestV0] Promote and Reject actions added * [KubernetesManifest] Create secret action (#9992) * [KubernetesManifest] Create secret action * Fixing annotations in tests * Merge pull request #10008 from Microsoft/users/nibansal/ImagePullSecretAddition ImagePullSecrets input added for KubernetesManifestV0 task * [KubernetesManifestV0] updating action name (#10029)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote action - If deployment strategy is 'Canary' it deletes canary deployment (canary and baseline objects) and deploy input manifests. If deployment strategy is not 'Canary', Error message is thrown.
Reject action - If deployment strategy is 'Canary' it deletes canary deployment (canary and baseline objects). and if deployment strategy is not 'Canary', Error message is thrown.
Code of other actions is refactored. Common code is moved to Helper classes.
kubectl-object-model is moved out of utility-commons.