Correctly detect directories and files in GitHub Release task #9877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you specify a direct path to a file, it should just attach the file. Given that the pattern is the same as the path in that case it currently fails.
mdmdakbar
approved these changes
Mar 20, 2019
| @@ -53,7 +53,7 @@ export class Utility { | |||
|
|
|||
| public static isPatternADirectory(assets: string[], pattern: string): boolean { | |||
| if (assets && assets.length === 1 && pattern) { | |||
| if (path.resolve(assets[0]) === path.resolve(pattern)) { | |||
| if ((path.resolve(assets[0]) === path.resolve(pattern)) && tl.exist(path.resolve(pattern)) && tl.stats(path.resolve(pattern)).isDirectory()) { | |||
There was a problem hiding this comment.
Thanks for making this change
mdmdakbar
pushed a commit
that referenced
this pull request
Mar 20, 2019
If you specify a direct path to a file, it should just attach the file. Given that the pattern is the same as the path in that case it currently fails.
mdmdakbar
pushed a commit
that referenced
this pull request
Mar 20, 2019
If you specify a direct path to a file, it should just attach the file. Given that the pattern is the same as the path in that case it currently fails.
mdmdakbar
pushed a commit
that referenced
this pull request
Mar 20, 2019
If you specify a direct path to a file, it should just attach the file. Given that the pattern is the same as the path in that case it currently fails.
mdmdakbar
added a commit
that referenced
this pull request
Mar 25, 2019
* Correctly detect directories (#9877) If you specify a direct path to a file, it should just attach the file. Given that the pattern is the same as the path in that case it currently fails. * Version update
mdmdakbar
added a commit
that referenced
this pull request
Mar 25, 2019
* Correctly detect directories (#9877) If you specify a direct path to a file, it should just attach the file. Given that the pattern is the same as the path in that case it currently fails. * Updating task version * version change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you specify a direct path to a file, it should just attach the file.
Given that the pattern is the same as the path in that case it currently fails.