Modifying the logic of uploading assets for proper log statements #9740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prativen
approved these changes
Mar 7, 2019
| "UploadAssetError": "An unexpected error occurred while uploading the asset: %s", | ||
| "UploadAssetSuccess": "Uploaded asset successfully: %s", | ||
| "UploadAssetSuccess": "Uploaded file successfully: '%s'", | ||
| "NoAssetFoundToUpload": "No assets were found to upload.", | ||
| "ReleaseNotesFileIsDirectoryError": "Release notes file: %s is a directory and not a file.", | ||
| "AssetIsDirectoryError": "The asset is a directory and not a file. Skipping uploading directory: %s", |
| "MissingAssetError": "File not found: %s", | ||
| "MultipleReleasesFoundError": "Only 1 release was expected but more than 1 release was found for tag: %s. Unable to perform the action.", | ||
| "MultipleTagFound": "Only 1 tag was expected but more than 1 tag was found for the given commit: %s. Unable to perform the action.", | ||
| "NoTagFound": "No tag was found for the provided target: %s. Skipping further steps...", | ||
| "NoTagFound": "Release will not be created as no tags could be found for the target commit. For more details check out the ‘Tag Source’ section in documentation: https://aka.ms/AA4f03a.", |
There was a problem hiding this comment.
aka.ms/GitHubReleaseTaskParameters ?
| return; | ||
| } | ||
|
|
||
| assets = assets.filter(asset => Utility.isFile(asset)); |
There was a problem hiding this comment.
we should include a log that folders ' , , , ' will be skipped?
* inputs error handling for yaml flow * Adding telemetry points * addressing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed: