Added task.json and taskdesign.md for new version of DotNetCoreInstal… #9729
Conversation
| } | ||
| } | ||
| catch (ex) { | ||
| tl.warning(tl.loc("FailedToCopyTopLevelFiles", ex)); |
There was a problem hiding this comment.
I was thinking of not failing if top level files can't be copied, as they might not impact the installation.
Also there might be cases of dotnet.exe stuck while running in background, which sometimes hinders in overwriting.
@sachinma If you feel strongly about it, we can fail here.
| // By default disable Multi Level Lookup unless user wants it enabled. | ||
| let restrictMultiLevelLookup = true; | ||
| try { | ||
| restrictMultiLevelLookup = tl.getBoolInput("restrictMultiLevelLookup", true); |
There was a problem hiding this comment.
It is not a required input, so if someone doesn't specify this input in yaml file. And due to tl.getboolinput's behaviour of always sending false as default (even in case input is missing), i am using getboolinput with required = true. so that if it throws, we can default to true value and disable multilevel lookup
There was a problem hiding this comment.
Cant you achieve this with the default value of true
There was a problem hiding this comment.
The library function is not exposing a function that returns back a default value of choice. So to know if the value is actually present or not I am passing required=true, so that it fails in case input is not define and then use default value.
| // By default disable Multi Level Lookup unless user wants it enabled. | ||
| let restrictMultiLevelLookup = true; | ||
| try { | ||
| restrictMultiLevelLookup = tl.getBoolInput("restrictMultiLevelLookup", true); |
There was a problem hiding this comment.
Cant you achieve this with the default value of true
|
Awesome, will this task get released soon or is it still under development? |
|
@bergmeister this will start rolling out starting next week and will reach all customers in around 3 more weeks. |
This PR is for V1 version of .Net core installer task. As part of V1 version we have implemented some new features and have tackled user requirements, such as these ones: #9758 #9608 #8306 #7754
New features: