Adding Docker V2 task - Simplify the task inputs for YAML #9707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vithati
reviewed
Mar 1, 2019
bansalaseem
reviewed
Mar 7, 2019
| addLabel(command, hostName, "build.repository.name", "BUILD_REPOSITORY_NAME"); | ||
| } | ||
|
|
||
| export function addBuildLabels(command: ToolRunner, hostName: string): void { |
There was a problem hiding this comment.
Add suffix of Args to all such function. We should add pipeline labels for build .
| export function addCommonLabels(command: ToolRunner, hostName: string): void { | ||
| addLabel(command, hostName, "system.teamfoundationcollectionuri", "SYSTEM_TEAMFOUNDATIONCOLLECTIONURI"); | ||
| addLabel(command, hostName, "system.teamproject", "SYSTEM_TEAMPROJECT"); | ||
| addLabel(command, hostName, "build.repository.name", "BUILD_REPOSITORY_NAME"); |
There was a problem hiding this comment.
build.repository.name should probably be pipeline.repository.name
| if (hostName) { | ||
| addCommonLabels(command, hostName); | ||
| let hostType = tl.getVariable("SYSTEM_HOSTTYPE"); | ||
| if (hostType.toLowerCase() === "build") { |
There was a problem hiding this comment.
is the hostType pipeline as well for pipelines? If not, can you please file a bug on build team for this
There was a problem hiding this comment.
hostType is build only. You will be writing the mail as discussed.
ajinkya599
commented
Mar 7, 2019
ajinkya599
commented
Mar 7, 2019
ajinkya599
commented
Mar 8, 2019
ajinkya599
changed the title
ajinkya599
force-pushed
the
users/aj/dockerV2
branch
3 times, most recently
from
24c9063 to
0e92fe5
Compare
bansalaseem
reviewed
Mar 15, 2019
…ner registry type and other complex inputs which can be supported using arguments
- Fixed some issues with buildAndPush and login - Added debug logs - bumping up versions of other tasks dependent on docker-common (causing PR build failures)
… up KubernetesV1 version
- Bump up versions for tasks depending on docker-common (Use milestone versioning)
ajinkya599
force-pushed
the
users/aj/dockerV2
branch
from
44cb515 to
7301a9e
Compare
|
When will this be available for use in Pipelines? Attempts at using it result in the following error: "An error occurred while loading the YAML build pipeline. wrong number of segments" |
|
It should be available in next 3-4 weeks on Azure Devops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the task inputs for YAML by removing Container registry type and other complex inputs which can be supported using arguments.
Added support for multiple logins/logouts.
Bumping up versions of other tasks dependent on docker-common. Using milestone based versioning. (DockerComposeV0, DockerV0, DockerV1, KubernetesV0, KubernetesV1)