Update cred provider version and enable V2 #9354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satbai
changed the title
satbai
force-pushed
the
users/satbai/updateCredProviderVersion
branch
from
51596d0 to
ce2b482
Compare
shubham90
reviewed
Jan 18, 2019
| @@ -9,7 +9,7 @@ | |||
| "version": { | |||
| "Major": 2, | |||
| "Minor": 147, | |||
| "Patch": 1 | |||
There was a problem hiding this comment.
Are there any other tasks that can call that packaging-common codepath?
There was a problem hiding this comment.
Does the .NET CLI task use it to configure NuGet.config (not sure if that is relevant in this context though).
There was a problem hiding this comment.
The NuGetCommandV2 is the only task that uses the cred provider and therefore the only task that will call isCredentialProviderEnabled. Dotnet tasks handle auth a bit differently - I believe the task adds the creds to a temp nuget.config so there's no need for a cred provider.
shubham90
approved these changes
Jan 18, 2019
satbai
added a commit
that referenced
this pull request
Jan 22, 2019
* Enable V2 cred provider based on NuGet version * Use nuget cred provider version 0.1.11 * Bump version
magleaso
added a commit
to magleaso/azure-pipelines-tasks
that referenced
this pull request
Jan 23, 2019
* support for canary added * Add support for AzureChinaCloud * task updated * task updated - diff of canary objects removed * Bug fixes done * code refactoring done * New conditions added to check rollout status * Unused dependencies removed * Try adding version in filter function * Fix upper/lower case mismatch * Retrying on failure to get connection data * Adding dockercli installer task in task list Signed-off-by: Rajendra Kolli <rakol@microsoft.com> * [ARG Deploy] Adding SPN to environment for override (microsoft#9347) * [ARG Deploy] Adding SPN to environment for override * Moving input to Advanced section * [KubernetesManifest] Adding actions scale, patch (microsoft#9286) * [KubernetesManifest] Adding actions scale, patch * Updating strings * Resolving PR comments * code refactoring * Master merged and conflicts resolved * Review changes and code refactoring done * Reverting change in the getWebApiWithProxy call * Use correct javascript syntax * isDigit is not a javascript function * Make sure this works then revert this commit * Revert change * Update cred provider version and enable V2 (microsoft#9354) * Enable V2 cred provider based on NuGet version * Use nuget cred provider version 0.1.11 * Bump version * change case in task folder name (microsoft#9367) * Importing Sqlserver module (microsoft#9359) * Importing Sqlserver module * updating task.json * Indentation * review changes done * update artifact-engine version (microsoft#9372) * Review changes and code refactoring done * Strings updated * Modifying metadata pushed by app service deploy task (microsoft#9371) * review changes done * XamarinAndroidV1: don't clean multiple times (microsoft#9378) * Change DownloadGitHubReleases case to match folder
satbai
added a commit
that referenced
this pull request
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.