Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of help URLs that can be displayed without Markdown parsing #9332

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

davidstaheli
Copy link
Contributor

Nearly every task has a helpMarkDown property that looks like this, and the surrounding Markdown isn't very useful:

"helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?LinkID=613718)",

@vtbassmatt, are you okay with me adding helpURl properties for raw help URLs to the tasks? To date, the tasks only have them embedded in the helpMarkDown property. They look pretty ugly when displayed in our logs unparsed. It would be nicer to have the raw URLs that UIs can render however they'd like.

If you agree with this PR, then later I'd like to validate the URLs (some point to GitHub instead of our docs) and bump the tasks' patch version numbers.

Copy link
Member

@vtbassmatt vtbassmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

@davidstaheli davidstaheli merged commit be07655 into master Jan 15, 2019
@davidstaheli davidstaheli deleted the users/davidstaheli/helpUrls branch January 15, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants