Added DuffleToolInstaller Task #9287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you ensure the codeowners file is updated with the new tasks that are being introduced. |
madhuv-msft
approved these changes
Mar 4, 2019
Tasks/DuffleInstallerV0/Strings/resources.resjson/en-US/resources.resjson
Show resolved
Hide resolved
| { | ||
| "dependencies": { | ||
| "@types/node": "^6.0.101", | ||
| "@types/q": "^1.5.0", |
There was a problem hiding this comment.
do you need types as dependencies or devdependencies?
| import { download } from 'utility-common/downloadutility'; | ||
|
|
||
| const DuffleToolName = 'duffle'; | ||
| const DuffleLatestReleaseUrl = 'https://api.github.com/repos/deislabs/Duffle/releases/latest'; |
There was a problem hiding this comment.
kubernetes task had this problem, we had to download all releases, if we are supporting >= or == kind of notation. deepak can help in this. for your today check-in this may be okay
There was a problem hiding this comment.
Yes. I will move that code to common and will use here once it checked-in.
| return tl.getVariable('agent.tempDirectory') || os.tmpdir(); | ||
| } | ||
|
|
||
| function getExecutableExtension(): string { |
vithati
requested review from
kmkumaran,
madhurig,
prativen,
RoshanKumarMicrosoft and
sachinma
as code owners
vithati
force-pushed
the
users/vithati/duffle
branch
from
29143f8 to
a480ee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.