Download Pipeline Artifact V1 #9067

owenhuynMSFT · 2018-12-13T00:40:21Z

No description provided.

…uyn/DownloadPipelineArtifactV1

…neArtifactV1 Changing the task version to V0 and V1 respectively

Tasks/DownloadPipelineArtifactV1/task.json

Tasks/DownloadPipelineArtifactV0/task.json

TingluoHuang · 2019-01-16T20:26:37Z

Make sure think through all compat cases between agent and task.
old agent vs. old task
old agent vs. new task
new agent vs. old task
new agent vs. new task

owenhuynMSFT · 2019-01-16T22:39:50Z

We will have the new agent code released for M146 while the task code will be released for M147 to avoid compat issues.

mizho · 2019-01-16T22:56:21Z

Tasks/DownloadPipelineArtifactV1/Strings/resources.resjson/zh-CN/resources.resjson

@@ -0,0 +1,12 @@
+{
+  "loc.friendlyName": "下载管道项目",


"loc.friendlyName": "下载管道项目",

Who did this? Google Translator? I need to talk to whoever did this. This is utterly wrong.

@mitchdenny - do we, as developers, have any say here in localization? I don't speak all the languages, but in this, the translation for both pipeline and artifact feelweird and/or wrong. If I translate them back to you, it means tube item.

mizho · 2019-01-16T22:57:18Z

Tasks/DownloadPipelineArtifactV1/Strings/resources.resjson/ja-jp/resources.resjson

@@ -0,0 +1,12 @@
+{
+  "loc.friendlyName": "パイプラインの成果物をダウンロードします",


This makes more sense than CN version.

mitchdenny · 2019-01-17T19:54:22Z

Thanks for doing this guys. Important to get this right! From: mizho <notifications@github.com> Sent: January 17, 2019 10:42 AM To: Microsoft/azure-pipelines-tasks <azure-pipelines-tasks@noreply.github.com> Cc: Mitch Denny <midenn@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Microsoft/azure-pipelines-tasks] Download Pipeline Artifact V1 (#9067) @mizho approved this pull request.

________________________________ In Tasks/DownloadPipelineArtifactV1/Strings/resources.resjson/zh-CN/resources.resjson<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fazure-pipelines-tasks%2Fpull%2F9067%23discussion_r248483056&data=02%7C01%7Cmidenn%40microsoft.com%7C245b2f1e018b4e94566408d67cab73d9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833473159636349&sdata=gJsAYeQk6yZcf9GUY10Dh5pCAajOKbDvx3lpqqlxfxM%3D&reserved=0>:

@@ -0,0 +1,12 @@

+{ + "loc.friendlyName": "下载管道项目", "loc.friendlyName": "下载管道项目", Who did this? Google Translator? I need to talk to whoever did this. This is utterly wrong.

________________________________ In Tasks/DownloadPipelineArtifactV1/Strings/resources.resjson/ja-jp/resources.resjson<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fazure-pipelines-tasks%2Fpull%2F9067%23discussion_r248483309&data=02%7C01%7Cmidenn%40microsoft.com%7C245b2f1e018b4e94566408d67cab73d9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833473159636349&sdata=ImTUyTl3LvIWk4oQ0CVEzM0sgMsnqV85yY4yjQ3J1W0%3D&reserved=0>:

@@ -0,0 +1,12 @@

+{ + "loc.friendlyName": "パイプラインの成果物をダウンロードします", This makes more sense than CN version.

________________________________ In Tasks/DownloadPipelineArtifactV1/Strings/resources.resjson/zh-CN/resources.resjson<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fazure-pipelines-tasks%2Fpull%2F9067%23discussion_r248487354&data=02%7C01%7Cmidenn%40microsoft.com%7C245b2f1e018b4e94566408d67cab73d9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833473159636349&sdata=P5sHeFOEyR413lN8HPvBqfUXnmeXi6GMMzRU9MUUWNo%3D&reserved=0>:

@@ -0,0 +1,12 @@

+{ + "loc.friendlyName": "下载管道项目", @mitchdenny<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmitchdenny&data=02%7C01%7Cmidenn%40microsoft.com%7C245b2f1e018b4e94566408d67cab73d9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833473159636349&sdata=174wuUzadk%2FwmrtLu21dkwgC1nctF4bWpGj31%2BbddfQ%3D&reserved=0> - do we, as developers, have any say here in localization? I don't speak all the languages, but in this, the translation for both pipeline and artifact feelweird and/or wrong. If I translate them back to you, it means tube item. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fazure-pipelines-tasks%2Fpull%2F9067%23pullrequestreview-193392853&data=02%7C01%7Cmidenn%40microsoft.com%7C245b2f1e018b4e94566408d67cab73d9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833473159636349&sdata=bDsF80dRrdJi0Ej33gIr0z5AElh3YjqhyxAxz2%2BIUe4%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAfVdsiFAnpcgKmTuJoCRcpyaXLDvoiXks5vEMPwgaJpZM4ZQtm_&data=02%7C01%7Cmidenn%40microsoft.com%7C245b2f1e018b4e94566408d67cab73d9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833473159792601&sdata=nyV7swTzoRqdxtd94%2BdYqrpqzWMiwvWx6l1wxoVE4ww%3D&reserved=0>.

TingluoHuang · 2019-01-17T20:54:59Z

Tasks/DownloadPipelineArtifactV1/task.json

+    "groups": [],
+    "demands": [],
+    "preview": true,
+    "minimumAgentVersion": "2.147",


jahsu-MSFT · 2019-01-18T18:29:51Z

Tasks/DownloadPipelineArtifactV1/Strings/resources.resjson/zh-TW/resources.resjson

@@ -0,0 +1,12 @@
+{
+  "loc.friendlyName": "下載管線成品",


This doesn't make much sense in traditional CN either...

MihaifGit

@TingluoHuang approved

owenhuynMSFT and others added 5 commits November 20, 2018 10:28

Initial commit for DownloadPipelineArtifactV1.

cac9879

Initial commit for DownloadPipelineArtifactV1.

f10d881

Changing the task version to V0 and V1 respectively

14b8718

Merge branch 'users/owhuyn/DownloadPipelineArtifactV1' into users/owh…

6d68522

…uyn/DownloadPipelineArtifactV1

Merge pull request #1 from fadnavistanmay/users/owhuyn/DownloadPipeli…

672675d

…neArtifactV1 Changing the task version to V0 and V1 respectively

owenhuynMSFT commented Dec 20, 2018

View reviewed changes

Tasks/DownloadPipelineArtifactV1/task.json Outdated Show resolved Hide resolved

TingluoHuang reviewed Jan 16, 2019

View reviewed changes

Tasks/DownloadPipelineArtifactV0/task.json Outdated Show resolved Hide resolved

owenhuynMSFT added 2 commits January 16, 2019 12:57

Fixed compat issues and min agent version.

1580c41

Removed change to renaming plugin name to V0.

b80f62c

Deleted localization for download pipeline artifacts V1 task.

d2fa7c0

mizho approved these changes Jan 17, 2019

View reviewed changes

TingluoHuang reviewed Jan 17, 2019

View reviewed changes

Changed min agent version to 2.147.0

2650992

jahsu-MSFT reviewed Jan 18, 2019

View reviewed changes

Fixed typo in loc.json and added US localization.

aeb716f

TingluoHuang merged commit d6bf92b into microsoft:master Jan 29, 2019

MihaifGit reviewed Jan 31, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Download Pipeline Artifact V1 #9067

Download Pipeline Artifact V1 #9067

owenhuynMSFT commented Dec 13, 2018

TingluoHuang commented Jan 16, 2019

owenhuynMSFT commented Jan 16, 2019

mizho Jan 16, 2019

mizho Jan 16, 2019

mizho Jan 16, 2019

mitchdenny commented Jan 17, 2019 via email

TingluoHuang Jan 17, 2019

owenhuynMSFT Jan 17, 2019

jahsu-MSFT Jan 18, 2019

MihaifGit left a comment

		@@ -0,0 +1,12 @@
		{
		"loc.friendlyName": "パイプラインの成果物をダウンロードします",

Download Pipeline Artifact V1 #9067

Download Pipeline Artifact V1 #9067

Conversation

owenhuynMSFT commented Dec 13, 2018

TingluoHuang commented Jan 16, 2019

owenhuynMSFT commented Jan 16, 2019

mizho Jan 16, 2019

Choose a reason for hiding this comment

mizho Jan 16, 2019

Choose a reason for hiding this comment

mizho Jan 16, 2019

Choose a reason for hiding this comment

mitchdenny commented Jan 17, 2019 via email

TingluoHuang Jan 17, 2019

Choose a reason for hiding this comment

owenhuynMSFT Jan 17, 2019

Choose a reason for hiding this comment

jahsu-MSFT Jan 18, 2019

Choose a reason for hiding this comment

MihaifGit left a comment

Choose a reason for hiding this comment