increasing retry #8983
Merged
increasing retry #8983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoshanKumarMicrosoft
requested review from
kmkumaran,
vincent1173 and
SumiranAgg
vincent1173
approved these changes
Dec 3, 2018
| @@ -100,7 +100,7 @@ export class FirewallRules { | |||
| deferred.reject(new azureServiceClient.ApiResult(azureServiceClient.ToError(response))); | |||
| } | |||
| else if(statusCode === 202){ | |||
| this._recursiveGetCall(resourceGroupName, serverName, firewallRuleName, 3, 0).then((response) => { | |||
| this._recursiveGetCall(resourceGroupName, serverName, firewallRuleName, 5, 0).then((response) => { | |||
There was a problem hiding this comment.
instead of making it a constant. Can we make it a secondary variable so that user can customize the time, he need to retry?
There was a problem hiding this comment.
This can also help in checking the L2 by changing the variable in RD json.
There was a problem hiding this comment.
This is good idea but no customer has reported any issue due to this . Once they will ask We will add this one .
| @@ -138,6 +138,7 @@ | |||
| "ASE_SSLIssueRecommendation": "To use a certificate in App Service, the certificate must be signed by a trusted certificate authority. If your web app gives you certificate validation errors, you're probably using a self-signed certificate and to resolve them you need to set a variable named VSTS_ARM_REST_IGNORE_SSL_ERRORS to the value true in the build or release definition", | |||
| "FailedToGetAzureMetricAlerts": "Failed to get Azure metric alerts: %s. Error: %s", | |||
| "FailedToUpdateAzureMetricAlerts": "Failed to update Azure metric alert rule '%s' Resource. Error: %s", | |||
| "ResponseNotValid": "Response is not in a valid format" | |||
| "ResponseNotValid": "Response is not in a valid format", | |||
| "NotAbleToCreateFirewallRule": "Getting error during adding firewall rule to azure mysql server. Error: %s" | |||
There was a problem hiding this comment.
nit: change azure to Azure. Please verify the help string with PM once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.