-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Release task suggestions #8922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks David for taking your time to review it.
"Create": "Create", | ||
"Edit": "Edit", | ||
"Discard": "Discard" | ||
"create": "Create", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used this value as $(action) in instanceNameFormat property below. So that task name can be modified according to action. For e.g. Create GitHub Release or Edit GitHub Release. But Lowercasing the options will lead to create GitHub Release or edit GitHub Release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdmdakbar, ah... I see what you mean. To the user, these values are case-insensitive when used in their YAML pipelines. Most GitHub users will use the typical YAML camel-casing and lowercase the the action
value on their own, like this:
- task: GithubRelease@0
inputs:
action: create
gitHubConnection: myConnection
Since most people will lowercase it in their YAML (no matter what casing is used in task.yaml), what would you think about changing instanceNameFormat
to have the action at the end, like this?
- GitHub release (create)
- GitHub release (edit)
- GitHub release (discard)
Since GitHub documentation refers to deleting a release, this PR also proposes that we use delete as the action name instead of discard. |
Hi @mdmdakbar. I hope I've resolved everyone's feedback on this. I'll merge it based on your approval, but please let me know if I can help change anything later. Thanks very much for considering this PR! |
* GitHubRelease suggestions * Updates for PR feedback * Suggestion: use "delete" instead of "discard" to match GitHub wording
* GitHub Release task suggestions (#8922) * GitHubRelease suggestions * Updates for PR feedback * Suggestion: use "delete" instead of "discard" to match GitHub wording * Fixing indentation issue in readme file (#9050) * renaming folder name to match with make-options json (#9061) * renaming folder name to match with make-options json * Adding telemetry points for the GitHub release task (#9068) * Adding telemetry points * Making few more changes to support case insensitive action input and failing the when invalid action input is provided * Modifyingstrings
Can you please consider these tweaks to the new GitHub Release task?