Add Task Azure IoT Edge and AzureIoTEdge in make-options.json #8901

michaeljqzq · 2018-11-23T08:59:18Z

No description provided.

prativen

Include version in the task folder name V2. Refer other task folders

prativen · 2018-11-23T12:38:50Z

Tasks/AzureIoTEdge/Strings/resources.resjson/en-US/resources.resjson

@@ -0,0 +1,62 @@
+{


Include version in the task folder name V2. Refer other task folders

prativen · 2018-11-23T12:44:27Z

Tasks/AzureIoTEdge/util.ts

+  public static validateModuleJson(moduleJsonObject: any): void {
+    // Will throw error if parent property does not exist
+    if (moduleJsonObject.image.tag.platforms == undefined) {
+      throw new Error(`${Constants.fileNameModuleJson} image.tag.platforms not set`);


should move these literals to task.json messages

validateModuleJson and validateDeployTemplateJson method are no longer used and I'll remove them.
Moved the literal in setTaskRootPath method to task.json

prativen · 2018-11-23T12:46:05Z

Tasks/AzureIoTEdge/util.ts

+
+  // Check if self(task) is included in a build pipeline
+  public static checkSelfInBuildPipeline(): boolean {
+    let hostType = tl.getVariable('system.hostType').toLowerCase();


are we differentiating task behaviour based on whether the task is included in CI or CD?

Yes. But we didn't use different code logic to treat it. We just print out this information for help user debug issues.

prativen · 2018-11-23T12:46:47Z

make-options.json

@@ -12,6 +12,7 @@
        "AzureFileCopyV1",
        "AzureFileCopyV2",
        "AzureFunctionV1",
+        "AzureIoTEdge",


rename the task folder to AzureIoTEdgeV2

prativen · 2018-11-23T12:50:16Z

Tasks/AzureIoTEdge/task.json

+    "Release"
+  ],
+  "author": "Microsoft",
+  "version": {


we should add "preview":true

we should let the second version be in preview for a while to get feedback

added preview tag

kmkumaran · 2018-11-23T13:55:21Z

Tasks/AzureIoTEdge/task.json

+  ],
+  "author": "Microsoft",
+  "version": {
+    "Major": 2,


Typically we release a new major version first as preview before making it public . Not sure if you want to do the same. If so, add "preview": "true",

added preview tag

kmkumaran · 2018-11-23T13:56:08Z

Tasks/AzureIoTEdge/task.json

+  "name": "AzureIoTEdge",
+  "friendlyName": "Azure IoT Edge",
+  "description": "Azure IoT Edge",
+  "helpMarkDown": "",


Have a link that can take to your help documentation.

Maybe I need to add links to docs ? Can I add link to our own github so that we can manage the issues, change log more conveniently? Or is there other best practices?

recommend add link to the docs. We need to close on the removal of the second git hub which we can discuss seperately.

recommend using an aka.ms url so that the link can be updated offline to point to the right url

kmkumaran · 2018-11-23T14:07:20Z

Tasks/AzureIoTEdge/telemetry.ts

@@ -0,0 +1,38 @@
+import * as appInsights from 'applicationinsights';


Are we pushing telemetry data? Typically all in-built task pushes data to Kusto using ##vso[telemetry.publish. Also I am not sure if it is ok in on-premise TFS to push data like this to AppInsights..

Yes. We're sending some telemetry data to Application Insights for usage statistics. We have a statement for the telemetry, and user can disable the telemetry by setting variable DISABLE_TELEMETRY to true.

In on-premise server, we push telemetry data only when user gives consent.

I have several questions about telemetry on on-premise server

In on-premise server, typically you push data to Kusto. Does that need user consent?

Can I detect if the task is running in on-premise server or DevOps? If yes, I think we can choose to push to Application Insights when the server is DevOps (Maybe push to Kusto for on-premise server)

If we change to logic to push all telemetry data to Kusto, how can our team query the data and use it for analytics
Thanks

And our telemetry to AI will not persist(last for 2 days), then a back-end service will route these data to Kusto (under Visual Studio org). So in concept we also use Kusto to record telemetry.

two things here:

We should try and push telemetry only for hosted AzureDevops . I will get back on what parameter you can check to make the telemetry call

Recommend you also push to kusto as well as all inhouse tasks telemetry is gathered here

Also, assuming failure to log telemetry does not fail the task

use tl.getVariable("System.ServerType") and check it for 'hosted' value
Reference: https://github.com/Microsoft/azure-pipelines-tasks/blob/01c1662494fb46710c1100a35d1ccb60e1126cdb/Tasks/Common/packaging-common/locationUtilities.ts

you can simply call telemetry.emit telemetry https://github.com/Microsoft/azure-pipelines-tasks/blob/1d75fa8f66aa1cf7a9cb62946939f30f087b2969/Tasks/Common/utility-common/telemetry.ts

See usage reference here: https://github.com/Microsoft/azure-pipelines-tasks/blob/8d0b72bb738b0916a0fd364336d9ecd597171373/Tasks/NpmV1/npm.ts

kmkumaran · 2018-11-23T14:11:15Z

Tasks/AzureIoTEdge/package-lock.json

@@ -0,0 +1,111 @@
+{
+  "name": "azure-iot-edge-vsts-extension-task",


Please ensure that the OSS dependencies and the specified versions are approved in OSS tool and have been code scanned. You might also need a ThirdPartyNotices.txt. @vincentdass as FYI.

prativen · 2018-11-27T10:08:31Z

Tasks/AzureIoTEdgeV2/task.json

+    "Build",
+    "Release"
+  ],
+  "author": "Microsoft",


"author": "Microsoft Corporation",

* Add Task Azure IoT Edge and AzureIoTEdge in make-options.json * Rename task, remove unused code logic, refine task metadata * Add ThirdPartyNotice * Update description for the task and the aka.ms link to documentation * Add common telemetry and only send AI telemetry on hosted server * Change author

* Add Task Azure IoT Edge and AzureIoTEdge in make-options.json (#8901) * Add Task Azure IoT Edge and AzureIoTEdge in make-options.json * Rename task, remove unused code logic, refine task metadata * Add ThirdPartyNotice * Update description for the task and the aka.ms link to documentation * Add common telemetry and only send AI telemetry on hosted server * Change author * Fix ts file case and align author change in task.loc.json (#8928) * Include author change in task.loc.json * Rename all ts files to lowercase

Add Task Azure IoT Edge and AzureIoTEdge in make-options.json

4a18542

prativen reviewed Nov 23, 2018

View reviewed changes

kmkumaran reviewed Nov 23, 2018

View reviewed changes

michaeljqzq added 4 commits November 26, 2018 13:24

Rename task, remove unused code logic, refine task metadata

a4a4cb6

Add ThirdPartyNotice

752af88

Update description for the task and the aka.ms link to documentation

705a5f9

Add common telemetry and only send AI telemetry on hosted server

e96a617

prativen approved these changes Nov 27, 2018

View reviewed changes

prativen reviewed Nov 27, 2018

View reviewed changes

Tasks/AzureIoTEdgeV2/task.json Outdated

"Build",

"Release"

],

"author": "Microsoft",

Copy link

Member

prativen Nov 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"author": "Microsoft Corporation",

Change author

f18fc76

chshrikh merged commit 9d274be into microsoft:master Nov 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Task Azure IoT Edge and AzureIoTEdge in make-options.json #8901

Add Task Azure IoT Edge and AzureIoTEdge in make-options.json #8901

michaeljqzq commented Nov 23, 2018

prativen left a comment

prativen Nov 23, 2018

prativen Nov 23, 2018

michaeljqzq Nov 26, 2018

prativen Nov 23, 2018

michaeljqzq Nov 26, 2018

prativen Nov 23, 2018

michaeljqzq Nov 26, 2018

prativen Nov 23, 2018

prativen Nov 23, 2018

michaeljqzq Nov 26, 2018

kmkumaran Nov 23, 2018

michaeljqzq Nov 26, 2018

kmkumaran Nov 23, 2018

michaeljqzq Nov 26, 2018

prativen Nov 27, 2018

prativen Nov 27, 2018

kmkumaran Nov 23, 2018 •

edited

Loading

michaeljqzq Nov 26, 2018

kmkumaran Nov 26, 2018

michaeljqzq Nov 27, 2018

michaeljqzq Nov 27, 2018

prativen Nov 27, 2018

prativen Nov 27, 2018

prativen Nov 27, 2018

prativen Nov 27, 2018

prativen Nov 27, 2018

kmkumaran Nov 23, 2018

michaeljqzq Nov 27, 2018

prativen Nov 27, 2018

		@@ -0,0 +1,38 @@
		import * as appInsights from 'applicationinsights';

		@@ -0,0 +1,111 @@
		{
		"name": "azure-iot-edge-vsts-extension-task",

Add Task Azure IoT Edge and AzureIoTEdge in make-options.json #8901

Add Task Azure IoT Edge and AzureIoTEdge in make-options.json #8901

Conversation

michaeljqzq commented Nov 23, 2018

prativen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kmkumaran Nov 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kmkumaran Nov 23, 2018 •

edited

Loading